Skip to content

Suppress known entitlement warnings #124883

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Mar 18, 2025
Merged

Suppress known entitlement warnings #124883

merged 1 commit into from
Mar 18, 2025

Conversation

@prdoyle
Copy link
Contributor

@prdoyle prdoyle commented Mar 14, 2025 •
edited
Loading

The work here is to copy over the settings from https://github.com/elastic/elasticsearch-serverless/pull/3639 and distribute them into the right log4j2.properties files.

See ES-11258.

@prdoyle prdoyle added >non-issue auto-backport Automatically create backport pull requests when merged test-entitlements v8.18.1 v8.19.0 v9.0.1 v9.1.0 :Core/Infra/Entitlements Entitlements infrastructure labels Mar 14, 2025
@prdoyle prdoyle self-assigned this Mar 14, 2025
@elasticsearchmachine elasticsearchmachine added the Team:Core/Infra Meta label for core/infra team label Mar 14, 2025
@elasticsearchmachine
Copy link
Collaborator

elasticsearchmachine commented Mar 14, 2025

Pinging @elastic/es-core-infra (Team:Core/Infra)

@prdoyle prdoyle force-pushed the sometimes-modular-s3 branch from abd43be to 01e5f15 Compare March 14, 2025 13:40
@prdoyle prdoyle marked this pull request as draft March 14, 2025 13:49
@prdoyle prdoyle changed the title Silence AWS entitlement warnings for inference plugin Silence known entitlement warnings for cloud plugins Mar 14, 2025
@prdoyle prdoyle marked this pull request as ready for review March 17, 2025 13:20
@prdoyle prdoyle changed the title Silence known entitlement warnings for cloud plugins Suppress known entitlement warnings Mar 17, 2025
@prdoyle prdoyle marked this pull request as draft March 18, 2025 13:22
@prdoyle prdoyle force-pushed the sometimes-modular-s3 branch from d3ae8ee to 0b1c09e Compare March 18, 2025 13:45
@prdoyle prdoyle marked this pull request as ready for review March 18, 2025 13:45
@prdoyle prdoyle force-pushed the sometimes-modular-s3 branch from 0b1c09e to 61dae07 Compare March 18, 2025 13:46
@prdoyle
Copy link
Contributor Author

prdoyle commented Mar 18, 2025

To reviewers: for discovery-gce and inference, I added brand new log4j2.properties config files that weren't there before. I'm not sure I've done everything necessary to make sure those get picked up.

ldematte
ldematte approved these changes Mar 18, 2025
View reviewed changes
Copy link
Contributor

@ldematte ldematte left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@prdoyle prdoyle enabled auto-merge (squash) March 18, 2025 14:08
@prdoyle prdoyle merged commit fd51f44 into elastic:main Mar 18, 2025
22 checks passed
@prdoyle prdoyle deleted the sometimes-modular-s3 branch March 18, 2025 14:52
This was referenced Mar 18, 2025
Merged
Merged
Merged
@elasticsearchmachine
Copy link
Collaborator

elasticsearchmachine commented Mar 18, 2025

💚 Backport successful

Status Branch Result
✅ 8.18
✅ 8.x
✅ 9.0

prdoyle added a commit to prdoyle/elasticsearch that referenced this pull request Mar 18, 2025
@prdoyle
Silence known entitlement warnings (elastic#124883)
392a1e5
prdoyle added a commit to prdoyle/elasticsearch that referenced this pull request Mar 18, 2025
@prdoyle
Silence known entitlement warnings (elastic#124883)
6f4c26d
elasticsearchmachine pushed a commit that referenced this pull request Mar 18, 2025
@prdoyle
Silence known entitlement warnings (#124883) (#125108)
6a5c69c
elasticsearchmachine pushed a commit that referenced this pull request Mar 18, 2025
@prdoyle
Silence known entitlement warnings (#124883) (#125106)
4f7947c
elasticsearchmachine pushed a commit that referenced this pull request Mar 18, 2025
@prdoyle
Silence known entitlement warnings (#124883) (#125107)
5e39d22
omricohenn pushed a commit to omricohenn/elasticsearch that referenced this pull request Mar 28, 2025
@prdoyle @omricohenn
Silence known entitlement warnings (elastic#124883)
0c77c81
@prdoyle prdoyle mentioned this pull request Apr 8, 2025
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@ldematte ldematte ldematte approved these changes

Assignees

@prdoyle prdoyle

Labels

auto-backport Automatically create backport pull requests when merged :Core/Infra/Entitlements Entitlements infrastructure >non-issue Team:Core/Infra Meta label for core/infra team v8.18.1 v8.19.0 v9.0.1 v9.1.0

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@prdoyle @elasticsearchmachine @ldematte